This repository was archived by the owner on Aug 2, 2023. It is now read-only.
Repository navigation
Conversation
Utilizes IDataReader.GetSchemaTable() to deduce column names and types, then reads rows into the DataFrame
|
|
|
@jmbeamer: Thank you for opening this PR. Do you think you could add some unit tests too? |
Author
|
@pgovind: Sure — I'll add some this weekend |
pgovind
reviewed
Sep 3, 2020
| /// <param name="numberOfRowsToRead">number of rows to read not including the header(if present)</param> | ||
| /// <param name="addIndexColumn">add one column with the row index</param> | ||
| /// <returns><see cref="DataFrame"/></returns> | ||
| public static DataFrame FromDataReader(IDataReader reader, string[] columnNames = null, Type[] dataTypes = null, long numberOfRowsToRead = -1, bool addIndexColumn = false) |
There was a problem hiding this comment.
When the PR was opened initially, this is how LoadCsv may have looked. When this PR becomes active again, we should finalize the shape/parameters in this API.
pgovind
added
the
OpenBeforeArchiving
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not quite as straightforward as a LoadSql() method but I think this route offers a great amount of flexibility for importing data from many sources without introducing a dependency nightmare.